Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLAC in mp4 typo in AtomParsers #6396

Closed
kgrevehagen opened this issue Sep 5, 2019 · 1 comment
Closed

FLAC in mp4 typo in AtomParsers #6396

kgrevehagen opened this issue Sep 5, 2019 · 1 comment
Assignees
Labels

Comments

@kgrevehagen
Copy link

[REQUIRED] Issue description

When trying to play FLAC in mp4, it goes through the AtomParsers.java and near the bottom in parseAudioSampleEntry() there is a check if childAtomSize == Atom.TYPE_dfLa. It seems like a typo and it should be childAtomType == Atom.TYPE_dfLa instead, just as all the others. This is where it sets the initializationData, so obviously this condition will never be hit.

[REQUIRED] Reproduction steps

Try to play a FLAC in mp4(e.g. using DASH) and observe that the initializationData in FlacDecoder is never set.

[REQUIRED] Link to test content

I don't have any testable content to send at the moment, but I can probably create a test file if you need it.

[REQUIRED] A full bug report captured from the device

N/A

[REQUIRED] Version of ExoPlayer being used

2.10.4

[REQUIRED] Device(s) and version(s) of Android being used

100% reproducible on Pixel 3 with Android 9

@andrewlewis
Copy link
Collaborator

Thanks for reporting! We will submit a fix.

ojw28 pushed a commit that referenced this issue Sep 10, 2019
Issue: #6396
PiperOrigin-RevId: 267536336
@ojw28 ojw28 closed this as completed Sep 10, 2019
ojw28 pushed a commit that referenced this issue Sep 17, 2019
Issue: #6396
PiperOrigin-RevId: 267536336
@google google locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants