Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfflineLicenseHelper does not have customizable DRM session. #7078

Closed
gregmcox opened this issue Mar 13, 2020 · 4 comments
Closed

OfflineLicenseHelper does not have customizable DRM session. #7078

gregmcox opened this issue Mar 13, 2020 · 4 comments
Assignees

Comments

@gregmcox
Copy link

Hello,
Currently, I have the need to customize the load error handling policy for an offline license request. Since the DefaultDrmSession is created within the helper, this is not really possible. I was wondering the rationale behind not exposing the DrmSession during the creation of OfflineLicenseHelper.

I'm in a use-case where I'm unable to modify the base ExoPlayer libraries and extending OfflineLicenseHelper is not possible as it's a final class.

Please let me know if it's a good idea and I'll submit a pull request.

Thanks!

Documentation:
https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/drm/OfflineLicenseHelper.html

@tonihei
Copy link
Collaborator

tonihei commented Mar 13, 2020

There is no particular reason for that. The LoadErrorHandlingPolicy in DrmSessionManager is relatively new, so that's why this wasn't asked before.

I'll update the class to accept a customized DefaultDrmSessionManager.

@gregmcox
Copy link
Author

@tonihei, I've created the pull request. Please let me know if it's sufficient.

@tonihei
Copy link
Collaborator

tonihei commented Mar 16, 2020

Thanks for the pull request - as mentioned above I already had a pending change that fixes the problem on our dev branch, so I'll go ahead and merge this one instead. Please give it a try once ready to see if it fixes your issue.

@gregmcox
Copy link
Author

Thanks for the fast turn around! Could you reference your commit here? I'm not seeing it on the dev-v2 branch.

ojw28 pushed a commit that referenced this issue Mar 19, 2020
This allows to customize the DrmSessionManager, e.g. with a
LoadErrorHandlingPolicy.

Issue:issue:#7078
PiperOrigin-RevId: 301571783
@ojw28 ojw28 closed this as completed Mar 19, 2020
@google google locked and limited conversation to collaborators May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants