-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OfflineLicenseHelper does not have customizable DRM session. #7078
Comments
There is no particular reason for that. The LoadErrorHandlingPolicy in DrmSessionManager is relatively new, so that's why this wasn't asked before. I'll update the class to accept a customized DefaultDrmSessionManager. |
@tonihei, I've created the pull request. Please let me know if it's sufficient. |
Thanks for the pull request - as mentioned above I already had a pending change that fixes the problem on our dev branch, so I'll go ahead and merge this one instead. Please give it a try once ready to see if it fixes your issue. |
Thanks for the fast turn around! Could you reference your commit here? I'm not seeing it on the dev-v2 branch. |
This allows to customize the DrmSessionManager, e.g. with a LoadErrorHandlingPolicy. Issue:issue:#7078 PiperOrigin-RevId: 301571783
Hello,
Currently, I have the need to customize the load error handling policy for an offline license request. Since the DefaultDrmSession is created within the helper, this is not really possible. I was wondering the rationale behind not exposing the DrmSession during the creation of OfflineLicenseHelper.
I'm in a use-case where I'm unable to modify the base ExoPlayer libraries and extending OfflineLicenseHelper is not possible as it's a final class.
Please let me know if it's a good idea and I'll submit a pull request.
Thanks!
Documentation:
https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/drm/OfflineLicenseHelper.html
The text was updated successfully, but these errors were encountered: