Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad overlay view leaks via IMA AdsManager after destruction without ALL_ADS_COMPLETED #7344

Closed
andrewlewis opened this issue May 7, 2020 · 1 comment
Closed

Ad overlay view leaks via IMA AdsManager after destruction without ALL_ADS_COMPLETED #7344

andrewlewis opened this issue May 7, 2020 · 1 comment
Assignees
@andrewlewis
Labels
bug: in dependency

Comments

@andrewlewis
Copy link
Collaborator

Issue description

In the IMA extension, if the AdsManager is destroyed before the ALL_ADS_COMPLETED event is raised by IMA, the ad overlay view is leaked, which in turn can leak its activity.

Note: This is a bug in dependency, but I'm filing this issue as a tracking bug for people who want to be updated on the status of the issue. [Internal: b/155041144]

Reproduction steps

Run the demo app. Attach Android Studio profiler. Run an ad playback with the IMA extension. Return to the sample chooser. Take a heap dump and observe that the PlayerActivity has leaked.

Link to test content

Reproduces using IMA samples in the demo app.

A full bug report captured from the device

n/a as already diagnosed.

Version of ExoPlayer being used

dev-v2

Device(s) and version(s) of Android being used

Reproducible on API 29 emulator with Play Store.
@andrewlewis andrewlewis self-assigned this May 7, 2020
This was referenced May 7, 2020
Closed
Closed
@andrewlewis andrewlewis mentioned this issue Jun 30, 2020
Closed
ojw28 pushed a commit that referenced this issue Nov 2, 2020
@andrewlewis @ojw28
Upgrade IMA SDK dependency to 3.21.0
16c60ec 
Call the new method AdsLoader.release() to allow the IMA SDK to dispose of its
WebView.

Issue: #7344
PiperOrigin-RevId: 339022162
icbaker pushed a commit that referenced this issue Nov 30, 2020
@andrewlewis @icbaker
Upgrade IMA SDK dependency to 3.21.0
7cc129d 
Call the new method AdsLoader.release() to allow the IMA SDK to dispose of its
WebView.

Issue: #7344
PiperOrigin-RevId: 339022162
ojw28 pushed a commit that referenced this issue Jan 12, 2021
@andrewlewis @ojw28
Upgrade IMA SDK dependency to 3.22.0
e3620ed 
Issue: #7344
Issue: #8339
PiperOrigin-RevId: 351212047
@fpitters
Copy link

fpitters commented Feb 1, 2021

Great! Thank you!

@google google locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
bug: in dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewlewis @fpitters