Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation need to be updated on how to compile Exoplayer 2.12.0 apps with androidx.work library dependency #7997

Closed
Rexee opened this issue Sep 27, 2020 · 2 comments
Assignees

Comments

@Rexee
Copy link

Rexee commented Sep 27, 2020

[REQUIRED] Issue description

If you use androidx.work and ExoPlayer with version 2.12.0 you need to add additional undocumented settings to gradle file described in issue: #7905 (comment)
If Exoplayer 2.12.0 cannot work with androidx.work library without these changes, then it should be officially documented because androidx.work is really popular. Currently we need to check closed issues to find solution.
Google have similar problem and recommend to include "councurrent-futures" dependency in gradle file: https://developer.android.com/topic/libraries/architecture/workmanager/advanced/listenableworker, can this problem be solved with similar approach?

[REQUIRED] Reproduction steps

Described in #7905

[REQUIRED] Link to test content

Described in #7905

[REQUIRED] A full bug report captured from the device

Described in #7905

[REQUIRED] Version of ExoPlayer being used

2.12.0

[REQUIRED] Device(s) and version(s) of Android being used

any

@rial1106
Copy link

I had to add a the guava dependancy since listenablefuture wasn't found. It took a lot of work to find the soloution

implementation 'com.google.guava:guava:29.0-android'

@icbaker
Copy link
Collaborator

icbaker commented Oct 14, 2020

Thanks for flagging - I agree these errors are pretty confusing.

I've sent a change switching ExoPlayer to depend on Guava as 'api', which I believe resolves both #7905 and #7993.

I'm not going to make any additional documentation changes - in the short term people can find these issues until the 'api' dependency change is included in a release.

ojw28 pushed a commit that referenced this issue Oct 17, 2020
The 'implementation' dependency causes problems when resolving
ListenableFuture in contexts that also include the
com.google.guava:listenablefuture:1.0 dependency.

Issue: #7905
Issue: #7997
Issue: #7993
PiperOrigin-RevId: 337093024
@icbaker icbaker closed this as completed Oct 21, 2020
ojw28 pushed a commit that referenced this issue Oct 21, 2020
The 'implementation' dependency causes problems when resolving
ListenableFuture in contexts that also include the
com.google.guava:listenablefuture:1.0 dependency.

Issue: #7905
Issue: #7997
Issue: #7993
PiperOrigin-RevId: 337093024
@google google locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants