Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Crash in DownloadManager.java #8419

Closed
logituitrel opened this issue Dec 31, 2020 · 2 comments
Closed

Fatal Crash in DownloadManager.java #8419

logituitrel opened this issue Dec 31, 2020 · 2 comments
Assignees
Labels

Comments

@logituitrel
Copy link

logituitrel commented Dec 31, 2020

We are facing a crash captured in crashlytics.
We are not sure about the steps to replicate this.
Are there any steps to tackle these crashes/ are they fixed in any upcoming exoplayer release?
Exoplayer version: 2.11.8

Logs:

Fatal Exception: java.lang.IllegalStateException
at com.google.android.exoplayer2.util.Assertions.checkState(Assertions.java:81)
at com.google.android.exoplayer2.offline.DownloadManager$InternalHandler.putDownloadWithState(DownloadManager.java:1159)
at com.google.android.exoplayer2.offline.DownloadManager$InternalHandler.onRemoveTaskStopped(DownloadManager.java:1117)
at com.google.android.exoplayer2.offline.DownloadManager$InternalHandler.onTaskStopped(DownloadManager.java:1078)
at com.google.android.exoplayer2.offline.DownloadManager$InternalHandler.handleMessage(DownloadManager.java:728)
at android.os.Handler.dispatchMessage(Handler.java:110)
at android.os.Looper.loop(Looper.java:203)
at android.os.HandlerThread.run(HandlerThread.java:61)
@ojw28
Copy link
Contributor

ojw28 commented Jan 3, 2021

It looks like this crash can occur when you remove a download and immediately re-add it (by calling DownloadManager.addDownload or DownloadService.sendAddDownload) with a non-zero stop reason.

We will work on a fix. Thanks for reporting!

ojw28 added a commit that referenced this issue Jan 5, 2021
Issue: #8419
#minor-release
PiperOrigin-RevId: 350134719
@ojw28
Copy link
Contributor

ojw28 commented Jan 5, 2021

This is fixed by the change ref'd above. It will be included in 2.12.3. We don't have a set release date, but I would expect it to be toward the end of this month.

@ojw28 ojw28 closed this as completed Jan 5, 2021
icbaker pushed a commit that referenced this issue Jan 11, 2021
Issue: #8419
PiperOrigin-RevId: 350134719
@google google locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants