You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exoplayer can't show stream from ip camera because of RtpMap header with trailing space. I don't know if it is a camera's firmware bug or it was made intentionally, but no change in camera settings removes that trailing space. Some players (e.g VLC) plays this steam correctly. I'm still using an ExoPlayer fork with RTSP support (before is was added to official repo), and nothing of them has such blocker.
Here is additional trailing space that causes error: a=rtpmap:96 H264/90000␣
Proposed solution
As I see, header looks normal and can be used as normal with skipping trailing spacer after splitting parameter. Moreover, the library uses only first two values, but checks that split result counts to exactly two in MediaDescriptor.java:47:
Also, Util.split() just calls value.split(regex, -1);. Calling rtpmapString.split(" ") or more specific call rtpmapString.split(" ", 0) will be enough to enhance the situation.
Exoplayer can't show stream from ip camera because of RtpMap header with trailing space. I don't know if it is a camera's firmware bug or it was made intentionally, but no change in camera settings removes that trailing space. Some players (e.g VLC) plays this steam correctly. I'm still using an ExoPlayer fork with RTSP support (before is was added to official repo), and nothing of them has such blocker.
As described in #9014 I have RTSP response:
Here is additional trailing space that causes error:
a=rtpmap:96 H264/90000␣
Proposed solution
As I see, header looks normal and can be used as normal with skipping trailing spacer after splitting parameter. Moreover, the library uses only first two values, but checks that split result counts to exactly two in MediaDescriptor.java:47:
Also, Util.split() just calls
value.split(regex, -1);
. CallingrtpmapString.split(" ")
or more specific callrtpmapString.split(" ", 0)
will be enough to enhance the situation.Similar headers processing issues: #9247, #9114, #9182
The text was updated successfully, but these errors were encountered: