Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve EssentialProperty from a DashManifest image Representation #9579

Closed
mestefy opened this issue Oct 19, 2021 · 2 comments
Closed

Retrieve EssentialProperty from a DashManifest image Representation #9579

mestefy opened this issue Oct 19, 2021 · 2 comments
Assignees

Comments

@mestefy
Copy link

mestefy commented Oct 19, 2021

I have the following AdaptionSet from a DASH manifest file

<AdaptationSet id="3" mimeType="image/jpeg" contentType="image">
      <SegmentTemplate media="template_goes_here">
        <SegmentTimeline>
          <S d="40000" r="126"/>
          <S d="24000"/>
        </SegmentTimeline>
      </SegmentTemplate>
      <Representation id="10" bandwidth="36864" width="1280" height="720" frameRate="0">
        <EssentialProperty schemeIdUri="http://dashif.org/guidelines/thumbnail_tile" value="5x5"/>
      </Representation>
</AdaptationSet>

As you can see, it defines the template for images of sizes 1280x720 and in the Representation we have an EssentialProperty of value 5x5 which describes the fact that the image is basically an image atlas of 25 images each of 256x144 each.

Is there a way to retrieve that EssentialProperty so that I can display the correct tile from that image?

I have checked the property essentialProperties from the AdaptionSet class however it is an empty list and the Representation.MultiSegmentRepresentation does not seem to have an essentialProperties of it's own, just the inbandEventStreams property.

As a side note I have found this related issue, however the fix for it seems to just set the image width and height from the representation in the format structure.

Thanks in advance!

@tonihei
Copy link
Collaborator

tonihei commented Nov 15, 2021

Although we parse the values, we currently don't save the result in the Representation class. Will mark as an enhancement.

tonihei added a commit that referenced this issue Nov 15, 2021
We already parse essential and supplemental properties from the
Representation, but don't add them to our Representation class so that
they can be accessed by users.

Issue: #9579
PiperOrigin-RevId: 409961990
tonihei added a commit that referenced this issue Nov 18, 2021
We already parse essential and supplemental properties from the
Representation, but don't add them to our Representation class so that
they can be accessed by users.

Issue: #9579
PiperOrigin-RevId: 409961990
icbaker pushed a commit to androidx/media that referenced this issue Nov 19, 2021
We already parse essential and supplemental properties from the
Representation, but don't add them to our Representation class so that
they can be accessed by users.

Issue: google/ExoPlayer#9579
PiperOrigin-RevId: 409961990
@tonihei
Copy link
Collaborator

tonihei commented Dec 15, 2021

Added support by the commit above.

@tonihei tonihei closed this as completed Dec 15, 2021
@google google locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants