Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vector drawables for the SimpleExoPlayer player control buttons. #2285

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Use vector drawables for the SimpleExoPlayer player control buttons. #2285

merged 1 commit into from
Jan 3, 2017

Conversation

colinrtwhite
Copy link
Contributor

This is a simple pull request to update the SimpleExoPlayer player controls to use the default Material Design vector drawable icons provided by Google.

Here's what the UI looks like with the changes:
screenshot_20170102-231434

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@colinrtwhite
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 3, 2017
@ojw28
Copy link
Contributor

ojw28 commented Jan 3, 2017

Wont this crash applications running below API level 21 unless (a) they're using the support library and have configured their gradle file appropriately, or (b) they're using Android Studio? I don't think we want to place these kind of limitations on how the library can be used.

Can we add the vector drawables under drawable-v21, but also retain the existing png drawables for backward compatibility?

@colinrtwhite
Copy link
Contributor Author

The Gradle build process should automatically generate PNG drawables if the user's minSDK is below API 21 using the Vector Asset Studio (no configuration required). However, I agree it makes sense to include PNGs of these vectors in case they aren't using Gradle.

I've updated my PR to include PNGs for devices < API 21.

@ojw28
Copy link
Contributor

ojw28 commented Jan 3, 2017

Thanks!

@ojw28 ojw28 merged commit da9c10a into google:dev-v2 Jan 3, 2017
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants