Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract tags from SubRip subtitles, add support for alignment #4569

Closed
wants to merge 1 commit into from

Conversation

szaboa
Copy link
Contributor

@szaboa szaboa commented Jul 24, 2018

Extracted valid tags from srt subtitles (so those won't be rendered anymore) and added support for different alignments tags (based on SSA v4+ specification) such as {\an2} for example.

@szaboa szaboa changed the title #4306 - Extract tags from SubRip subtitles, add support for alignment Extract tags from SubRip subtitles, add support for alignment Jul 24, 2018
@szaboa szaboa mentioned this pull request Jul 24, 2018
@szaboa
Copy link
Contributor Author

szaboa commented Jul 26, 2018

Closing this pull request and sending a new one, where the source branch is a feature branch and not dev-2.

@szaboa szaboa closed this Jul 26, 2018
@szaboa szaboa deleted the dev-v2 branch July 26, 2018 16:45
@google google locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants