#4304 - Add option to show buffering view when setPlayWhenReady is false #4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Posted some minor comments that would be good to address, and then we'll get this merged. Thanks! |
|
ojw28
reviewed
Jul 27, 2018
| public void setShowBuffering(boolean showBuffering) { | ||
| setShowBuffering(showBuffering ? SHOW_BUFFERING_ALWAYS : SHOW_BUFFERING_NEVER); |
There was a problem hiding this comment.
It should use SHOW_BUFFERING_WHEN_PLAYING rather than SHOW_BUFFERING_ALWAYS, so that the behavior of this method doesn't change.
| @@ -51,7 +51,11 @@ | |||
| <attr name="hide_on_touch" format="boolean"/> | |||
| <attr name="hide_during_ads" format="boolean"/> | |||
| <attr name="auto_show" format="boolean"/> | |||
| <attr name="show_buffering" format="boolean"/> | |||
| <attr name="show_buffering" format="enum"> | |||
| <enum name="show_buffering_never" value="0"/> | |||
There was a problem hiding this comment.
Given how these are used, I think the names can probably be shortened to just "never" "always" and "when_playing".
| * <li>{@link #SHOW_BUFFERING_ALWAYS} displayed always when buffering | ||
| * <li>{@link #SHOW_BUFFERING_NEVER} not displayed at all | ||
| * <li>{@link #SHOW_BUFFERING_WHEN_PLAYING} displayed only when playing and buffering | ||
| * </p></ul> |
There was a problem hiding this comment.
Are </p> and </ul> the wrong way round (not sure :)).
| @@ -655,9 +666,28 @@ public void setKeepContentOnPlayerReset(boolean keepContentOnPlayerReset) { | |||
| * Sets whether a buffering spinner is displayed when the player is in the buffering state. The | |||
| * buffering spinner is not displayed by default. | |||
| * | |||
| * Deprecated, use {@link #setShowBuffering(int)} | |||
|
Oops, posted them now. Thanks! |
|
@ojw28 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to show buffering view when
playWhenReadyis set to false. So from now the visibility state can be defined with the following options:SHOW_BUFFERING_NEVERSHOW_BUFFERING_ALWAYSSHOW_BUFFERING_WHEN_PLAYINGChecked on emulator where I tweaked the network type / signal strength to be able to test it and it seemed OK to me in every case.
Link to the original issue: #4304