Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WorkManager extension #5617

Merged
merged 5 commits into from
May 20, 2019
Merged

add WorkManager extension #5617

merged 5 commits into from
May 20, 2019

Conversation

loki666
Copy link
Contributor

@loki666 loki666 commented Mar 11, 2019

implementation of Scheduler using Android Arch WorkManager

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@loki666
Copy link
Contributor Author

loki666 commented Mar 11, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ojw28
Copy link
Contributor

ojw28 commented Mar 14, 2019

Would you see this as replacing the jobdispatcher extension, or are there use cases for both?

@loki666
Copy link
Contributor Author

loki666 commented Mar 14, 2019

it can be a replacement, since WorkManager will either use platform JobDispatcher, Firebase/PlayStore jobDispatcher implementation or AlertManager depending on the API level or simple a background thread if the app is in the foreground

@loki666
Copy link
Contributor Author

loki666 commented Apr 2, 2019

is something missing in this PR ?

@ojw28
Copy link
Contributor

ojw28 commented Apr 5, 2019

Nothing is missing. We're just waiting for a convenient time to look at & merge this. Thanks!

Copy link
Contributor

@erdemguven erdemguven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix/respond pointed issues.

@loki666
Copy link
Contributor Author

loki666 commented Apr 16, 2019

since dev-v2 migrated to androidX, should I also change the dependency?
for androidX it should be 'androidx.work:work-runtime:2.0.1'

@erdemguven
Copy link
Contributor

Yes, please switch to androidX.

loki666 added 2 commits April 17, 2019 12:41
use androidX workmanager
@loki666
Copy link
Contributor Author

loki666 commented Apr 17, 2019

should be good

@erdemguven
Copy link
Contributor

Thanks

@ojw28 ojw28 merged commit 6c5a39a into google:dev-v2 May 20, 2019
ojw28 added a commit that referenced this pull request May 20, 2019
PiperOrigin-RevId: 248533906
@loki666 loki666 deleted the workmanager branch May 20, 2019 16:04
ojw28 added a commit that referenced this pull request Jul 28, 2019
PiperOrigin-RevId: 248533906
@google google locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants