-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add WorkManager extension #5617
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Would you see this as replacing the |
it can be a replacement, since WorkManager will either use platform JobDispatcher, Firebase/PlayStore jobDispatcher implementation or AlertManager depending on the API level or simple a background thread if the app is in the foreground |
is something missing in this PR ? |
Nothing is missing. We're just waiting for a convenient time to look at & merge this. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix/respond pointed issues.
...anager/src/main/java/com/google/android/exoplayer2/ext/workmanager/WorkManagerScheduler.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/com/google/android/exoplayer2/ext/workmanager/WorkManagerScheduler.java
Outdated
Show resolved
Hide resolved
since dev-v2 migrated to androidX, should I also change the dependency? |
Yes, please switch to androidX. |
use androidX workmanager
should be good |
Thanks |
implementation of Scheduler using Android Arch WorkManager