-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ascending sort of TrackGroup #7715
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
It seems I've made a mistake, when selecting the format (ie: 250p) it is not switching to it but to another one. |
In terms of making this API generally useful, could you design it so that the caller can pass any |
You're right, I'll use a |
I've been doing the sorting (inside |
Obsoleted by #7798 |
This enhancement match with this issue #7709
This is my first time contributing to a project, feel free to tell me if I did something wrong.
I'm comparing the bitrate of the
TrackGroup
as it works for both Audio and Video.I've also notice that the original
TrackGroup
fromtrackGroups.get(groupIndex);
is always 0, maybe I could delete the first loop over thegroupIndex