CEA-708 Decoder fixes for issue #1807 (Refactoring the PR #8356) #8415
Conversation
In this change - Handling the sequence number discontinuity in caption channel packet header. The processCurrentPacket returns if the packet length does not match with the currentIndex. That assumption is wrong. As per spec the the packet can end on reception of next cc_type = 0x3.
The handling sequence discontinuity and the packet with size less the packet_size is separated out to another PR google#8415
library/core/src/main/java/com/google/android/exoplayer2/text/cea/Cea708Decoder.java
Show resolved
Hide resolved
|
Thanks for splitting this out of the larger PR - this is much easier to review (and thanks also for the references to the spec, very helpful). You sent through a number of test streams - are there any specific ones that I can use to verify this change in particular? i.e. something that clearly fails before this change and succeeds after it? I tried the first one but it seems unaffected by this change. |
|
@icbaker thank you for looking at this PR. I have sent an e-mail to The stream which has the packet length set to 128 bytes but actual packet length shorter than that, unfortunately requires to be tested with the changes from PR #8356 to get the right caption displayed. If you are testing the changes from this PR alone, that simply displays few character with only one row, where as the actual caption has 4 rows. |
This pull request is for issue #1807. Refactoring the PR #8356
In this change -
Handling the sequence number discontinuity in caption channel packet header.
The processCurrentPacket returns if the packet length does not match with the currentIndex. That assumption is wrong. As per spec the the packet can end on reception of next cc_type = 0x3.