Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8906-Prevented negative seek position #9281

Closed

Conversation

LuGO0
Copy link
Contributor

@LuGO0 LuGO0 commented Aug 10, 2021

  1. According to the discussion I saw on Seeking to a negative value makes the ExoPlayer to pause over HLS #8906, tried to resolve this Issue
  2. Added Assertion for preventing negative seek position. closes Seeking to a negative value makes the ExoPlayer to pause over HLS #8906

@google-cla google-cla bot added the cla: yes label Aug 10, 2021
1. Added Assertion for preventing negative seek position.

Update CastPlayer.java
@LuGO0 LuGO0 force-pushed the 8906-Preventing-negative-seek-position branch from 70f58a0 to 38a3ccc Compare August 10, 2021 19:11
@nick-tkachov
Copy link

You can have negative seek position in Live playback if you have content buffered outside of the sliding window.

@LuGO0
Copy link
Contributor Author

LuGO0 commented Aug 16, 2021

You can have negative seek position in Live playback if you have content buffered outside of the sliding window.

Oops Did not know about it, will read about it more .

@ojw28
Copy link
Contributor

ojw28 commented Sep 6, 2021

Adding an assertion that'll crash applications if they attempt to pass negative seek positions seems pretty risky to me, and I'm not sure it's the correct solution. Let's use the issue (#8906) for any discussion about the correct solution.

@ojw28 ojw28 closed this Sep 6, 2021
@google google locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants