Add a utility to detect App Clips and make a semantic check for background URL sessions #220
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
force-pushed
the
harlan/hi-im-clippy
branch
from
a2bbc3d to
b427b4f
Compare
morganchen12
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Thanks! You should be able to fix the tests by cherry-picking c54e175.
…round URL sessions
harlanhaskins
force-pushed
the
harlan/hi-im-clippy
branch
from
b427b4f to
27cedee
Compare
|
Thanks so much for the review! Is this good to merge? |
|
Done, @harlanhaskins. I'll work on getting it released to unblock your other PR. |
|
Thank you so much! |
ncooke3
added a commit
that referenced
this pull request
May 1, 2025
ncooke3
added a commit
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two utility functions to
GULAppEnvironmentUtil.m:isAppClip, which determines heuristically whether the current app is an App Clip. I do not think it's necessarily required that app clips have this top level dictionary in their Info.plist, but in practice I would assume almost all do.supportsBackgroundURLSessionUploads, which checks both for app extensions and app clips and turns off background uploads for both of them.I have submitted a separate PR to
firebase-ios-sdkto make use ofsupportsBackgroundURLSessionUploads, because as of now AppClips fail when uploading files.