credProtect extension #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichelp
reviewed
May 14, 2020
gendx
reviewed
May 14, 2020
|
I moved the credProtect checks into storage.rs to let it check discoverability itself. And addressed your comments. Please let me know if you want to add the feature flag. |
ia0
previously approved these changes
May 27, 2020
jmichelp
reviewed
Jun 2, 2020
|
Just merged, added some more conversion functions. Will refactor to moving more values in a later PR. |
ia0
previously approved these changes
Jun 4, 2020
ia0
previously approved these changes
Jun 5, 2020
ia0
approved these changes
Jun 5, 2020
gendx
reviewed
Jun 8, 2020
1 task
|
Feature for #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the credProtect extension. This might need changes after #108 is merged.