Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Check reproducibility #180

Closed
wants to merge 1 commit into from
Closed

Conversation

ia0
Copy link
Member

@ia0 ia0 commented Oct 9, 2020

This is just to make sure that our build is not hermetic. As a consequence binaries are not reproducible.

@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@ia0 ia0 changed the title DO NOT COMMIT: Check reproducibility DO NOT MERGE: Check reproducibility Oct 9, 2020
@gendx
Copy link
Collaborator

gendx commented Oct 9, 2020

This is just to make sure that our build is not hermetic. As a consequence binaries are not reproducible.

Any more context on that? To me, it seems that over time reproducibility breaks because dependencies get updated and we don't pin a specific version via a Cargo.lock file. There is also the OS discrepancies that we're aware of (see #94 (comment) and rust-lang/cargo#8140).

But other than that binaries should be reproducible, and if there is any other unknown reason for non-reproducibility we should investigate.

@ia0 ia0 mentioned this pull request Oct 9, 2020
@ia0
Copy link
Member Author

ia0 commented Oct 9, 2020

The context is that the workflow for reproducibility is thus completely useless, because it tracks noise instead of signal. As such it should be disabled until this is fixed.

@ia0 ia0 closed this Oct 9, 2020
@ia0 ia0 deleted the not_reproducible branch October 9, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants