implicitly generate HMAC-secret #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ia0
previously approved these changes
Dec 8, 2020
jmichelp
reviewed
Dec 9, 2020
gendx
reviewed
Dec 9, 2020
jmichelp
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new version of the HMAC-secret extension. It does so by reverting the extension of key handles in #218, now implicitly creating
cred_randomvalues deterministically from the credential and 2 new device secrets.Part of #106 , but backwards compatible to the 2.0 version.
@jmichelp for checking the idea
@ia0 for storage
optional FYI @gendx for crypto (i.e.
generate_cred_random)