Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credBlob extension #265

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

kaczmarczyck
Copy link
Collaborator

This PR implements the credBlob extension.

At the same time, it facilitates the Extension data structures to have a default instead of being optional.

  • Tests pass
  • Appropriate changes to README are included in PR

@kaczmarczyck kaczmarczyck requested a review from jmichelp January 20, 2021 18:12
@kaczmarczyck kaczmarczyck self-assigned this Jan 20, 2021
@google-cla google-cla bot added the cla: yes label Jan 20, 2021
Copy link
Collaborator

@jmichelp jmichelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that my suggestion about deriving from Default was useful ;-)

@kaczmarczyck kaczmarczyck merged commit cdde644 into google:develop Jan 21, 2021
@kaczmarczyck kaczmarczyck deleted the cred-blob-extension branch January 21, 2021 08:27
@kaczmarczyck
Copy link
Collaborator Author

Still enough concepts in Rust that I don't know about, so keep them coming :)

@kaczmarczyck kaczmarczyck mentioned this pull request Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants