Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the last extension missing for CTAP 2.1. Also cleans up the
GetInfo
output for all options.One design choice made here is how we want to store the per-credential
largeBlobKey
. The specification mandates:largeBlobKey
largeBlobKey
when created duringMakeCredential
Therefore, we have to store per-credential information. I decided to go with the 32 byte array itself, as the cryptographically most straight-forward implementation.
We could sometimes save some memory by only storing a bool indicating existence, and later derive the
largeBlobKey
using a master secret similar tocredRandom
. This approach only pays off with the second created credentials that useslargeBlobKey
, because of the cost for master secrets. For users (including those never usinglargeBlobKey
at all), I expect this to be more expensive on average.