Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide openocd_cmd and add some documentation #492

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

foopub
Copy link
Contributor

@foopub foopub commented Jun 8, 2022

As per #405.

However I think the openocd documentation might be applicable to the other boards too, hence it might be better to put it in its own file? Let me know and feel free to edit.

Cheers

@coveralls
Copy link

coveralls commented Jun 8, 2022

Coverage Status

Coverage remained the same at 89.88% when pulling 9fe4421 on foopub:patch-1 into 667c269 on google:develop.

docs/boards/nrf52840_dongle.md Outdated Show resolved Hide resolved
docs/boards/nrf52840_dongle.md Outdated Show resolved Hide resolved
@foopub
Copy link
Contributor Author

foopub commented Jun 24, 2022

Addressed the comments, sorry for the delay, it had slipped my mind

Copy link
Collaborator

@jmichelp jmichelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments.
Also I noticed that your pull request is currently against stable. Please rebase against develop. We don't accept PRs on stable branch (basically, develop will be the next stable at some point).

docs/boards/nrf52840_dongle.md Outdated Show resolved Hide resolved
docs/boards/nrf52840_dongle.md Outdated Show resolved Hide resolved
@foopub foopub changed the base branch from stable to develop June 28, 2022 20:52
@foopub foopub force-pushed the patch-1 branch 2 times, most recently from 9f62ea2 to a9b1419 Compare June 28, 2022 21:09
@kaczmarczyck kaczmarczyck merged commit a9a67ae into google:develop Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants