What to submit for a issue?

[IllgamhoDuck]

TensorNetwork/tensornetwork/network_components.py

Lines 314 to 315 in 8a4f8eb

	def set_name(self, name) -> None:
	self.name = name

I'm trying to use the tensor network and testing it right now.
I just found that this line of code doesn't have protection.

So if I do ..

node = tn.Node(np.eye(2))
print(node) # __unnamed_node__
node.set_name(node)
print(node)

Type error occured not when I assign the name and occured when I try to print it out.
Because I sended the node instance to the self.name.

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-28-cdce2f239ef3> in <module>
----> 1 print(node)

TypeError: __str__ returned non-string (type Node)

Is this a problem or not? Is this kind of protection needed?

assert type(self.name) == str, "the name should be string type"

I'm not sure about is this could be an issue or not so I just posted a question here.
I tried to look for a guideline but hard to get a sense of the scope of how far I could post or fix.
https://github.com/google/TensorNetwork/blob/master/CONTRIBUTING.md

[chaserileyroberts]

Yeah, you could add that check. It would be in the __str__ definition of the Nodes class. Since it's pretty straight forward, would you be interested in trying to do a PR for this?

[IllgamhoDuck]

@Thenerdstation Yes for sure. It's just few line of code so not really hard. And I think it would be better to add in the set_name because it should make an error at that point when assigning the name not when we are printing.

Anyway, I'm digging on the codebase so for further I'll try to look at the protections and etc. I'm currently looking at the #292 (algebraic operations for BaseNode).