Skip to content
This repository was archived by the owner on Nov 7, 2024. It is now read-only.

Conversation

@mganahl
Copy link
Contributor

@mganahl mganahl commented Jan 12, 2021

No description provided.

@mganahl mganahl requested a review from alewis January 12, 2021 13:33
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #901 (2a086f5) into master (852638b) will decrease coverage by 0.00%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   98.13%   98.12%   -0.01%     
==========================================
  Files         129      129              
  Lines       22748    22780      +32     
==========================================
+ Hits        22323    22354      +31     
- Misses        425      426       +1     
Impacted Files Coverage Δ
tensornetwork/backends/abstract_backend.py 91.35% <50.00%> (-0.52%) ⬇️
tensornetwork/backends/jax/jax_backend.py 98.86% <100.00%> (+<0.01%) ⬆️
tensornetwork/backends/jax/jax_backend_test.py 99.27% <100.00%> (+<0.01%) ⬆️
tensornetwork/backends/numpy/numpy_backend.py 98.05% <100.00%> (+0.01%) ⬆️
tensornetwork/backends/numpy/numpy_backend_test.py 99.30% <100.00%> (+<0.01%) ⬆️
tensornetwork/backends/pytorch/pytorch_backend.py 99.50% <100.00%> (+<0.01%) ⬆️
...ornetwork/backends/pytorch/pytorch_backend_test.py 100.00% <100.00%> (ø)
...sornetwork/backends/symmetric/symmetric_backend.py 99.30% <100.00%> (+<0.01%) ⬆️
...twork/backends/symmetric/symmetric_backend_test.py 100.00% <100.00%> (ø)
...rnetwork/backends/tensorflow/tensorflow_backend.py 98.24% <100.00%> (+0.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852638b...2a086f5. Read the comment docs.

@mganahl mganahl mentioned this pull request Jan 12, 2021
@mganahl
Copy link
Contributor Author

mganahl commented Jan 14, 2021

@alewis, review appreciated!

@mganahl mganahl requested a review from jacksonwb January 14, 2021 21:58
@jacksonwb jacksonwb self-requested a review January 19, 2021 16:53
Copy link
Contributor

@jacksonwb jacksonwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mganahl mganahl merged commit 3ca4d03 into google:master Jan 20, 2021
@mganahl mganahl deleted the backend_eps branch January 20, 2021 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants