Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

[lighthouse] add "mixed content" reference #5758

Merged
merged 1 commit into from
Feb 7, 2018
Merged

[lighthouse] add "mixed content" reference #5758

merged 1 commit into from
Feb 7, 2018

Conversation

kaycebasques
Copy link
Contributor

What's changed, or what was fixed?

  • adds reference for the "mixed content" audit

Fixes: N/A

Target Live Date: 2018-02-08

  • This has been reviewed and approved by @kaycebasques (myself)
  • I have run gulp test locally and all tests pass.
  • I have added the appropriate type-something label.
  • I've staged the site and manually verified that my content displays correctly.

CC: @petele

@WebFundBot
Copy link

👍

@petele petele merged commit 4cf389e into master Feb 7, 2018
@petele petele deleted the lh-mixed branch February 7, 2018 14:35
@WebFundBot
Copy link

🎉 This has been pushed live to https://developers.google.com/web/

@christhompson
Copy link
Contributor

With GoogleChrome/lighthouse#4441, we'll have a clean way to invoke the new audit. @paulirish thinks it would be best to add the "how to run this audit" section to the existing docs here (see GoogleChrome/lighthouse#4444). I'd suggest something along the lines of:

How to use this audit

This audit is not run by default in Lighthouse, and currently requires that you have Chrome Canary installed. To use it, you will need to run the lighthouse command-line tool. You can install lighthouse using npm:

npm install -g lighthouse

To run the audit, you can use the included --mixed-content flag:

lighthouse --mixed-content http://www.example.com

This will create a new HTML Lighthouse report file in your current working directory.


I'd be happy to make a quick PR to add that, if you'd like.

<img src="images/not-fully-secure.png"
alt="Google Chrome (version 66) reporting that page is not fully secure."/>
<figcaption>
<b>Figure X</b>. Google Chrome (version 66) reporting that a page is not fully secure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the figures be numbered 1/2/etc. for the final version?

@christhompson
Copy link
Contributor

I drafted a quick PR with the potential additional docs #5764. Let me know what you think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants