Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Add help text about hover states to a11y how-to-review page #6384

Merged
merged 4 commits into from
Jul 19, 2018

Conversation

joelhsmith
Copy link
Contributor

What's changed, or what was fixed?

  • added help text about checking for hover states in the how to do an assessment page

Fixes: GoogleChrome/lighthouse#5667

Target Live Date: Next release

  • This has been reviewed and approved by @joelhsmith
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label. (I do not think I have permissions to add labels here)
  • I've staged the site and manually verified that my content displays correctly.

CC: @robdodson

@@ -167,6 +167,16 @@ sure it’s truly removed from the keyboard flow. The proposed [inert
attribute](https://github.com/WICG/inert) aims to make this easier by combining
the behavior of both attributes.

## Interactive elements like links and buttons should indicate their purpose and state

Providing visual hints about what an element does helps people operate and navigate a site or app. In user experience this is called affordance. Providing affordance makes it possible for people to use a site on a wide variety of devices.
Copy link
Contributor

@robdodson robdodson Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible way to tweak the phrasing a bit:

"Providing visual hints about what a control will do helps people operate and navigate your site. These hints are called affordances. Providing affordances makes it possible for people to your site on a wide variety of devices."

Copy link
Contributor

@robdodson robdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggested change.

@petele
Copy link
Member

petele commented Jul 17, 2018

Also note - this fails the build because {# wf_blink_components: (something) #} is missing from the top of the doc. @robdodson what should it be?

@robdodson
Copy link
Contributor

robdodson commented Jul 18, 2018 via email

@@ -5,6 +5,7 @@ description: How to review your site for accessibility issues.

{# wf_updated_on: 2017-07-24 #}
{# wf_published_on: 2017-03-12 #}
{# wf_blink_components: Blink>Accessibility #}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks for adding.

@petele
Copy link
Member

petele commented Jul 18, 2018

@robdodson - the correct tag would be {# wf_blink_components: Blink>Accessibility #}, which as added. thanks!

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@petele petele dismissed robdodson’s stale review July 19, 2018 23:58

requested changes were made.

@petele petele merged commit 0777773 into google:master Jul 19, 2018
@WebFundBot
Copy link

🎉 This has been pushed live to https://developers.google.com/web/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants