-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add help text about hover states to a11y how-to-review page #6384
Conversation
@@ -167,6 +167,16 @@ sure it’s truly removed from the keyboard flow. The proposed [inert | |||
attribute](https://github.com/WICG/inert) aims to make this easier by combining | |||
the behavior of both attributes. | |||
|
|||
## Interactive elements like links and buttons should indicate their purpose and state | |||
|
|||
Providing visual hints about what an element does helps people operate and navigate a site or app. In user experience this is called affordance. Providing affordance makes it possible for people to use a site on a wide variety of devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible way to tweak the phrasing a bit:
"Providing visual hints about what a control will do helps people operate and navigate your site. These hints are called affordances. Providing affordances makes it possible for people to your site on a wide variety of devices."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggested change.
Also note - this fails the build because |
Blink>Accessibility in crbug. Does that mean it would just be {#
wf_blink_components: Accessibility #} ?
…On Tue, Jul 17, 2018 at 4:23 PM Pete LePage ***@***.***> wrote:
Also note - this fails the build because {# wf_blink_components:
(something) #} is missing from the top of the doc. @robdodson
<https://github.com/robdodson> what should it be?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6384 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBFDW3XR0X8MlA9yyoLsSDeeDmDQhxLks5uHnHwgaJpZM4VS-3p>
.
|
@@ -5,6 +5,7 @@ description: How to review your site for accessibility issues. | |||
|
|||
{# wf_updated_on: 2017-07-24 #} | |||
{# wf_published_on: 2017-03-12 #} | |||
{# wf_blink_components: Blink>Accessibility #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks for adding.
@robdodson - the correct tag would be |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
🎉 This has been pushed live to https://developers.google.com/web/ |
What's changed, or what was fixed?
Fixes: GoogleChrome/lighthouse#5667
Target Live Date: Next release
npm test
locally and all tests pass.type-something
label. (I do not think I have permissions to add labels here)CC: @robdodson