Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

[lighthouse] add performance budget docs #7561

Merged
merged 1 commit into from
May 6, 2019
Merged

[lighthouse] add performance budget docs #7561

merged 1 commit into from
May 6, 2019

Conversation

kaycebasques
Copy link
Contributor

@kaycebasques kaycebasques commented May 1, 2019

What's changed, or what was fixed?

Fixes: N/A

Target Live Date: 2019-05-07

  • This has been reviewed and approved by @addyosmani or @khempenius
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label.
  • I've staged the site and manually verified that my content displays correctly.

CC: @petele

@addyosmani
Copy link
Contributor

Thank you so much for getting this content written up, Kayce! A quick sanity-check: are the Lighthouse performance audit docs moving to web.dev for next week or is the canonical source going to continue to be /web?

@kaycebasques
Copy link
Contributor Author

I think that's the long-term plan but wasn't aware of this being a requirement right now. Since the rest of the Lighthouse report UI won't be linking to web.dev next week, as far as I'm aware, I'd suggest keeping it consistent by having it all on /web for now. I might be wrong about all this though so let's get @paulirish & @Meggin in here...

@robdodson
Copy link
Contributor

@addyosmani @kaycebasques I think if this is only available from Lighthouse on the command line then it should live on /web. We have audit docs on web.dev but that's because they're relating directly back to the tool running on web.dev/measure.

@Meggin
Copy link
Contributor

Meggin commented May 3, 2019

We are in transition... best to keep tooling on /web... at least for now.

@addyosmani
Copy link
Contributor

addyosmani commented May 3, 2019 via email

@paulirish
Copy link
Member

This lgtm.

I made a few edits: 91e4dfe

Copy link
Contributor

@khempenius khempenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a couple minor nits, but otherwise LGTM.

src/content/en/tools/lighthouse/audits/budgets.md Outdated Show resolved Hide resolved
src/content/en/tools/lighthouse/audits/budgets.md Outdated Show resolved Hide resolved
src/content/en/tools/lighthouse/audits/budgets.md Outdated Show resolved Hide resolved
src/content/en/tools/lighthouse/audits/budgets.md Outdated Show resolved Hide resolved
src/content/en/tools/lighthouse/audits/budgets.md Outdated Show resolved Hide resolved
@kaycebasques kaycebasques force-pushed the budgets branch 2 times, most recently from 3d3dc48 to 2431960 Compare May 6, 2019 21:50
@WebFundBot
Copy link

Whoops!

There were 21 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

WARNINGS
src/content/en/tools/lighthouse/audits/budgets.md#L263 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/lighthouse/audits/budgets.md#L18 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L33 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L34 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L44 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L45 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L122 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L126 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L127 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L128 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L196 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L199 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L207 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L210 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L218 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L222 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L223 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L224 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L240 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L245 - Line must be at most 100 characters
src/content/en/tools/lighthouse/audits/budgets.md#L256 - Line must be at most 100 characters

@kaycebasques kaycebasques merged commit 857c80c into master May 6, 2019
@kaycebasques kaycebasques deleted the budgets branch May 6, 2019 22:12
@WebFundBot
Copy link

🎉 This has been pushed live to https://developers.google.com/web/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants