-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[lighthouse] add performance budget docs #7561
Conversation
Thank you so much for getting this content written up, Kayce! A quick sanity-check: are the Lighthouse performance audit docs moving to web.dev for next week or is the canonical source going to continue to be /web? |
I think that's the long-term plan but wasn't aware of this being a requirement right now. Since the rest of the Lighthouse report UI won't be linking to web.dev next week, as far as I'm aware, I'd suggest keeping it consistent by having it all on /web for now. I might be wrong about all this though so let's get @paulirish & @Meggin in here... |
@addyosmani @kaycebasques I think if this is only available from Lighthouse on the command line then it should live on /web. We have audit docs on web.dev but that's because they're relating directly back to the tool running on web.dev/measure. |
We are in transition... best to keep tooling on /web... at least for now. |
That sounds reasonable. Thanks for confirming!
…On Thu, May 2, 2019, 8:30 PM Meggin Kearney ***@***.***> wrote:
We are in transition... best to keep tooling on /web... at least for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7561 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA3C2NWYURIIAM56EGTPYDPTOWUBANCNFSM4HJRSM3Q>
.
|
This lgtm. I made a few edits: 91e4dfe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted a couple minor nits, but otherwise LGTM.
3d3dc48
to
2431960
Compare
🎉 This has been pushed live to https://developers.google.com/web/ |
What's changed, or what was fixed?
Fixes: N/A
Target Live Date: 2019-05-07
npm test
locally and all tests pass.type-something
label.CC: @petele