xnn_table_exp2minus_k_over_16 extern as uint32_t instead of int32_t #6832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_661630768
branch
3 times, most recently
from
c78e0f9 to
dc04e76
Compare
- table is really floats but declared as uint32_t - change extern to match usage PiperOrigin-RevId: 662190566
copybara-service
bot
force-pushed
the
test_661630768
branch
from
dc04e76 to
f483d6f
Compare
|
@fbarchard Changing these to unint32_t unfortunately does not solve the LTO warnings: #7261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xnn_table_exp2minus_k_over_16 extern as uint32_t instead of int32_t