-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xee does not provide correct data for resampled image #145
Comments
Thanks for raising the issue, @deepgabani8. Just for your information (jfyi), we internally work with asset_ids, so any manipulation made on images like these will not affect the data fetched from EE. |
Actually, we have a bug/issue in the codebase: https://github.com/google/Xee/blob/main/xee/ext.py#L789C1-L797C80. We consider 'asset_ids' at the time of processing, if we can obtain them. And we implemented this to avoid an expensive toList() operation. But it seems like it will cause issue like in your case. |
Add a new `fast_time_slicing` parameter. If True, Xee performs an optimization that makes slicing an ImageCollection across time faster. This optimization loads EE images in a slice by ID, so any modifications to images in a computed ImageCollection will not be reflected. For those familiar with the code before, the else flow in `_slice_collection` was only entered when images in the collection didn't have IDs. Clearing the image IDs triggered the else block. Also adds several new warnings: - if a user enables `fast_time_slicing` but there are no image IDs, and - if a user is indexing into a very large ImageCollection. Fixes #88 and #145. PiperOrigin-RevId: 623280839
Add a new `fast_time_slicing` parameter. If True, Xee performs an optimization that makes slicing an ImageCollection across time faster. This optimization loads EE images in a slice by ID, so any modifications to images in a computed ImageCollection will not be reflected. For those familiar with the code before, the else flow in `_slice_collection` was only entered when images in the collection didn't have IDs. Clearing the image IDs triggered the else block. Also adds several new warnings: - if a user enables `fast_time_slicing` but there are no image IDs, and - if a user is indexing into a very large ImageCollection. Fixes #88 and #145. PiperOrigin-RevId: 623815209
I think this PR in Xarray may provide a long term fix for this issue. |
#156 may have fixed this – needs verification. |
This colab script shows that Xee now produces different results for different resampling methods ('bilinear' and 'bicubic'). |
When I use
ee.data.computePixels
, it returns different data for different resample methods, which it should but fetching data using xee as backend returns the same data.Using
ee.data.computePixels
, which gives different data for resample methods = ['bilinear', 'bicubic'].Using Xee as the backend, which gives the same data for resample methods = ['bilinear', 'bicubic'].
The text was updated successfully, but these errors were encountered: