Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coordinates returned by XEE do not match EE cordinates #57

Closed
raspstephan opened this issue Oct 9, 2023 · 1 comment
Closed

Coordinates returned by XEE do not match EE cordinates #57

raspstephan opened this issue Oct 9, 2023 · 1 comment
Assignees
@alxmrs
Labels
bug Something isn't working P0

Comments

@raspstephan
Copy link

The coordinates in the xarray dataset do not match those that EE returns.

For example:
image

does not match
image

See this notebook as an example: https://colab.corp.google.com/drive/1-2rbTZF8BShnKF_RasSF0hQ8OoTpRY0C?usp=sharing
@alxmrs alxmrs added bug Something isn't working P1 labels Oct 9, 2023
@alxmrs
Copy link
Collaborator

alxmrs commented Oct 9, 2023

In the notebook, Stephan suggests a fix:

Could we literally just take ee.Image.pixelLonLat to determine the coordinates to avoid any confusion?

I think this is a brilliant idea!!

copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
Updating Integration Test Constants.
19288ad 
Updating constants as we begin to automate running integration tests.

More attention is needed here to tell if the coordinates are accurate. This will be addressed in #57.

PiperOrigin-RevId: 572275208
@copybara-service copybara-service bot mentioned this issue Oct 10, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
Updating Integration Test Constants.
cbd87bd 
Updating constants as we begin to automate running integration tests.

More attention is needed here to tell if the coordinates are accurate. This will be addressed in #57.

PiperOrigin-RevId: 572275208
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
Updating Integration Test Constants.
4a6f7d8 
Updating constants as we begin to automate running integration tests.

More attention is needed here to tell if the coordinates are accurate. This will be addressed in #57.

PiperOrigin-RevId: 572278845
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
Have Earth Engine calculate coordinate information.
a5c04ff 
Fixes #57. Per the suggestion of @raspstephan, we avoid computing lat/lng information ourselves and instead pull our coordinate information via RPC calls into EE. There didn't seem to be a good way to do this within `get_info()`, so this introduces two additional IO calls. This should only add overhead to the `open_dataset()` call (i.e. once) and not to every data index operation.

Running benchmarks now, so far:
```
open_dataset():avg=33.11,std=8.23,best=22.81,worst=48.00
```

PiperOrigin-RevId: 572063673
@copybara-service copybara-service bot mentioned this issue Oct 10, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
Have Earth Engine calculate coordinate information.
38662c3 
Fixes #57. Per the suggestion of @raspstephan, we avoid computing lat/lng information ourselves and instead pull our coordinate information via RPC calls into EE. There didn't seem to be a good way to do this within `get_info()`, so this introduces two additional IO calls. This should only add overhead to the `open_dataset()` call (i.e. once) and not to every data index operation.

Running benchmarks now, so far:
```
open_dataset():avg=33.11,std=8.23,best=22.81,worst=48.00
```

PiperOrigin-RevId: 572063673
@alxmrs alxmrs added P0 and removed P1 labels Oct 10, 2023
@alxmrs alxmrs self-assigned this Oct 10, 2023
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
Have Earth Engine calculate coordinate information.
a7cfde3 
Fixes #57. Per the suggestion of @raspstephan, we avoid computing lat/lng information ourselves and instead pull our coordinate information via RPC calls into EE. There didn't seem to be a good way to do this within `get_info()`, so this introduces two additional IO calls. This should only add overhead to the `open_dataset()` call (i.e. once) and not to every data index operation.

Running benchmarks now, so far:
```
open_dataset():avg=33.11,std=8.23,best=22.81,worst=48.00
open_and_chunk():avg=37.61,std=8.79,best=23.95,worst=53.59
```

PiperOrigin-RevId: 572063673
@raspstephan raspstephan mentioned this issue Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxmrs alxmrs

Labels
bug Something isn't working P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have Earth Engine calculate coordinate information. google/Xee
2 participants
@alxmrs @raspstephan