Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlowLayout] Deprecate FlowRow and FlowColumn #1494

Merged
merged 17 commits into from
May 3, 2023

Conversation

uchennafokoye
Copy link
Contributor

…owRow and FlowColumn in Androidx.Compose Foundations.

FlowLayouts is now supported in Androidx.Compose. Provided is a migration guide to move to the official version.

Please add the library name to the PR title. Example: "[Insets] Fixes typo"

…owRow and FlowColumn in Androidx.Compose Foundations.

FlowLayouts is now supported in Androidx.Compose. Provided is a migration guide to move to the official version.
@google-cla
Copy link

google-cla bot commented Jan 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This deprecates FlowRow and FlowColumn in Accompanist for the official FlowRow and FlowColumn in Androidx.Compose Foundations.

FlowLayouts is now supported in Androidx.Compose. Provided is a migration guide to move to the official version.
@uchennafokoye uchennafokoye changed the title Deprecating FlowRow and FlowColumn in Accompanist for the official Fl… [FlowLayout] Deprecate FlowRow and FlowColumn Jan 26, 2023
uchennafokoye and others added 2 commits January 26, 2023 18:04
This deprecates FlowRow and FlowColumn in Accompanist for the official FlowRow and FlowColumn in Androidx.Compose Foundations.

FlowLayouts is now supported in Androidx.Compose. Provided is a migration guide to move to the official version.
docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
uchennafokoye and others added 4 commits February 7, 2023 20:02
This deprecates FlowRow and FlowColumn in Accompanist for the official FlowRow and FlowColumn in Androidx.Compose Foundations.

FlowLayouts is now supported in Androidx.Compose. Provided is a migration guide to move to the official version.
Updates FlowLayout migration guide
@cbeyls
Copy link

cbeyls commented Apr 20, 2023

Currently the new FlowRow doesn't support verticalArrangement (only verticalAlignment) and the new FlowColumn doesn't support horizontalArrangement (only horizontalAlignment). This makes it impossible to add spacing between each row/column. Until this is supported, this version should not be deprecated.

@uchennafokoye
Copy link
Contributor Author

uchennafokoye commented Apr 25, 2023

Currently the new FlowRow doesn't support verticalArrangement (only verticalAlignment) and the new FlowColumn doesn't support horizontalArrangement (only horizontalAlignment). This makes it impossible to add spacing between each row/column. Until this is supported, this version should not be deprecated.

This has been fixed in the coming release. Please see more information here:
https://b.corp.google.com/issues/268365538

docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
docs/flowlayout.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bentrengrove bentrengrove merged commit eac532a into google:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants