Upgrade to Compose 1.6 #1691
Merged
Upgrade to Compose 1.6 #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentrengrove
commented
Aug 2, 2023
| @@ -33,7 +33,7 @@ systemProp.org.gradle.internal.http.socketTimeout=120000 | |||
|
|
|||
| GROUP=com.google.accompanist | |||
| # !! No longer need to update this manually when using a Compose SNAPSHOT | |||
| VERSION_NAME=0.31.7-SNAPSHOT | |||
| VERSION_NAME=0.33.0-alpha | |||
There was a problem hiding this comment.
Leaving 0.32 for the Compose 1.5 stable release
alexvanyo
approved these changes
Aug 7, 2023
| @@ -113,7 +81,7 @@ public class BottomSheetNavigatorSheetState(internal val sheetState: ModalBottom | |||
| @OptIn(ExperimentalMaterialApi::class) | |||
| @Composable | |||
| public fun rememberBottomSheetNavigator( | |||
| animationSpec: AnimationSpec<Float> = SwipeableDefaults.AnimationSpec | |||
| animationSpec: AnimationSpec<Float> = SpringSpec<Float>() | |||
There was a problem hiding this comment.
Nit: It looks like they behave the same, but I've usually seen spring() used instead of constructing a SpringSpec directly
Mwhite69
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665
Fixes #1671
Currently blocked by navigation material needing upgrades