Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placeholder documentation] Show deprecated message within the warning box #1724

Merged
merged 1 commit into from
Oct 21, 2023
Merged

[Placeholder documentation] Show deprecated message within the warning box #1724

merged 1 commit into from
Oct 21, 2023

Conversation

Monkey-Matt
Copy link
Contributor

Small formatting change so the warning message in the docs shows within the warning box rather than under it.

How it shows currently on https://google.github.io/accompanist/placeholder/
Screenshot 2023-10-20 at 9 59 21 AM

How I'd expect it to show (as seen on other pages)
Screenshot 2023-10-20 at 9 59 37 AM

@google-cla
Copy link

google-cla bot commented Oct 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ianhanniballake ianhanniballake merged commit f6785c2 into google:main Oct 21, 2023
9 checks passed
@Monkey-Matt Monkey-Matt deleted the Monkey-Matt-patch-1 branch November 29, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants