Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pager-indicators] Drop false-positive deprecation of pagerTabIndicatorOffset() #1755

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Philipp91
Copy link
Contributor

Fixes #1744.

The deprecation was intended to apply only to the old overload above, but was presumably copy-pasted by accident.

Fixes google#1744.

The deprecation was intended to apply only to the old overload above, but was presumably copy-pasted by accident.
@bentrengrove bentrengrove merged commit 5297607 into google:main Feb 27, 2024
9 checks passed
@bentrengrove
Copy link
Collaborator

Actually sorry, I just remembered this was deprecated on purpose. We need to update the docs.

We recommend just copying the implementation to your project as our implementation isn't maintained going forwards.

@joshrvezy
Copy link

Actually sorry, I just remembered this was deprecated on purpose. We need to update the docs.

We recommend just copying the implementation to your project as our implementation isn't maintained going forwards.

when you deprecate it, is there a migration strategy in place for whatever we are supposed to do to keep using indicators?
thanks

@bentrengrove
Copy link
Collaborator

More details here. For pager indicators the recommendation is just to copy the implementation into your own project and customize to your needs

https://medium.com/androiddevelopers/an-update-on-jetpack-compose-accompanist-libraries-august-2023-ac4cbbf059f1

@Philipp91
Copy link
Contributor Author

I believe an important (and correct?) piece of background information is that TabRow(indicator=...) and ScrollableTabRow(indicator=...) now have decent default values. So one does not need to call pagerTabIndicatorOffset() manually in order to get a reasonably working TabRow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect deprecation of pagerTabIndicatorOffset
3 participants