Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip extensions or files #75

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Skip extensions or files #75

merged 1 commit into from
Apr 28, 2021

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Apr 28, 2021

This PR adds the feature to skip extensions or files to be checked or add the license header.
In some cases, we don't want to add the headers for some files, and will be useful if we can just skip those.

After I did the implementation I saw the PR: #73

If the maintainers prefer the other approach I'm fine and we can close this PR

@lukehinds
Copy link

not a addlicense maintainer , but fwiy this is really useful. right now builds are failing as the code is looking for license headers in everything (including docs, , readmes, config files etc).

@mco-gh
Copy link
Contributor

mco-gh commented Apr 28, 2021

Hi, sorry for the delay. At a quick glance, PR 73 looks like it provides more functionality, because it supports patterns, not just extensions, and it supports excluding directories as well as individual files. Would it cover your needs? Any reason you wouldn't prefer it?

@cpanato
Copy link
Contributor Author

cpanato commented Apr 28, 2021

I'm not against it, just open it because I saw that PR after :/

I did some tests and that covers the use case we are looking to implement.

So I'm ok in close this in favor of #73 @mco-gh

@mco-gh
Copy link
Contributor

mco-gh commented Apr 28, 2021

Actually, on second thought, this covers the most common use case (extension based files) and it's a lot less involved (one file changed vs. 31) so I'm gonna go with this one. Thanks for the contrib! I may take the other one later but this feels like the safer option to add this functionality.

@Shabirmean
Copy link

Shabirmean commented May 27, 2021

@cpanato - Thanks for adding this!

@mco-gh - the 31 file changes on PR #73 is because I added extensive test cases :) Technically it only has one file change and everything else is a new test file added to validate different folder structures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants