Skip to content

fix: converts litellm generate config err #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonwei97 wants to merge 5 commits into from
Closed

fix: converts litellm generate config err #1509

simonwei97 wants to merge 5 commits into from

Conversation

@simonwei97
Copy link
Contributor

@simonwei97 simonwei97 commented Jun 19, 2025

Fixs: #1302

Previous PR: #1450

@simonwei97
Copy link
Contributor Author

simonwei97 commented Jun 19, 2025

@genquan9 pls review this PR.

genquan9
genquan9 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@genquan9 genquan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@genquan9 genquan9 added the ready to pull [Status] This PR is ready to be importing back to Google label Jun 23, 2025
copybara-service bot pushed a commit that referenced this pull request Jun 25, 2025
@simonwei97 @copybara-github
fix: converts litellm generate config err
ecb9638 
Merge #1509

Fixs: #1302

Previous PR: #1450

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 774803187
@copybara-service copybara-service bot mentioned this pull request Jun 25, 2025
Merged
copybara-service bot pushed a commit that referenced this pull request Jun 26, 2025
@simonwei97 @copybara-github
fix: converts litellm generate config err
351cd08 
Merge #1509

Fixs: #1302

Previous PR: #1450

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 774803187
copybara-service bot pushed a commit that referenced this pull request Jun 26, 2025
@simonwei97 @copybara-github
fix: converts litellm generate config err
3901fad 
Merge #1509

Fixs: #1302

Previous PR: #1450

COPYBARA_INTEGRATE_REVIEW=#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
@simonwei97
Copy link
Contributor Author

simonwei97 commented Jun 26, 2025

@genquan9 I saw that #1646 has been merged, this PR should be closed?

coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
@simonwei97 @copybara-github
fix: converts litellm generate config err
7f3e966 
Merge google#1509

Fixs: google#1302

Previous PR: google#1450

COPYBARA_INTEGRATE_REVIEW=google#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
seanzhou1023 pushed a commit to soundTricker/adk-python that referenced this pull request Jul 11, 2025
@simonwei97 @seanzhougoogle
fix: converts litellm generate config err
b15d000 
Merge google#1509

Fixs: google#1302

Previous PR: google#1450

COPYBARA_INTEGRATE_REVIEW=google#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
pandasanjay pushed a commit to pandasanjay/adk-python that referenced this pull request Jul 28, 2025
@simonwei97 @copybara-github
fix: converts litellm generate config err
67640da 
Merge google#1509

Fixs: google#1302

Previous PR: google#1450

COPYBARA_INTEGRATE_REVIEW=google#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
@surajksharma07 surajksharma07 self-assigned this Oct 6, 2025
@surajksharma07
Copy link
Collaborator

surajksharma07 commented Oct 6, 2025

Hi @simonwei97 and thanks to everyone who participated in this thread.

We're currently doing some housekeeping on our pull request queue. Given the rapid pace of development and the number of updates since this was last active, there's a good chance this pull request needs to be caught up to the latest version. To help us keep our backlog focused on current pull requests, we are closing this as stale.

If you're still interested in contributing to this change, could you please update to the very latest version of the library and create a new pull request? Our team will be glad to help with the refreshed PRs and answer any questions!

Thanks for your contribution and understanding!

@simonwei97
Copy link
Contributor Author

simonwei97 commented Oct 10, 2025

OK, I find this PR change has been included on main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@genquan9 genquan9 genquan9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@surajksharma07 surajksharma07

Labels

ready to pull [Status] This PR is ready to be importing back to Google

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simonwei97 @surajksharma07 @genquan9