fix: Update google_search_tool.py to support updated Gemini LIVE model naming #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l name fix: Update google_search_tool.py to support updated Gemini LIVE model name * New model name of 'gemini-live-...' doesn't pass the check of 'gemini-2' to access google search tool.
hangfei
approved these changes
Jun 25, 2025
hangfei
added
the
ready to pull
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
…l naming Merge google#1518 ## Description Fixes [google#1512](google#1512) by updating google_search_tool.py to support new Gemini LIVE model naming ## Changes - Update the model name checking in google_search_tool.py COPYBARA_INTEGRATE_REVIEW=google#1518 from rayira:rayira-patch-1 4c98f88 PiperOrigin-RevId: 775941268
Collaborator
|
This is already fixed in : |
seanzhou1023
pushed a commit
to soundTricker/adk-python
that referenced
this pull request
Jul 11, 2025
…l naming Merge google#1518 ## Description Fixes [google#1512](google#1512) by updating google_search_tool.py to support new Gemini LIVE model naming ## Changes - Update the model name checking in google_search_tool.py COPYBARA_INTEGRATE_REVIEW=google#1518 from rayira:rayira-patch-1 4c98f88 PiperOrigin-RevId: 775941268
pandasanjay
pushed a commit
to pandasanjay/adk-python
that referenced
this pull request
Jul 28, 2025
…l naming Merge google#1518 ## Description Fixes [google#1512](google#1512) by updating google_search_tool.py to support new Gemini LIVE model naming ## Changes - Update the model name checking in google_search_tool.py COPYBARA_INTEGRATE_REVIEW=google#1518 from rayira:rayira-patch-1 4c98f88 PiperOrigin-RevId: 775941268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1512 by updating google_search_tool.py to support new Gemini LIVE model naming
Changes