Add guard to prevent AttributeError in run_live for non-function tools
#274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
hangfei
added
the
ready to pull
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
Co-authored-by: Hangfei Lin <hangfei@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the resilience of the
_process_function_live_helpermethod by ensuring thatinspect.isasyncgenfunction(tool.func)is only called when thetoolobject actually has a func attribute.In current usage, when an agent is wrapped as a tool (e.g., AgentTool) and passed to run_live, it results in an AttributeError because AgentTool does not define .func. This fix adds a simple
hasattr(tool, "func")guard to ensure compatibility with both FunctionTool and AgentTool types.This change improves robustness without affecting functionality for tools that do include a func field.