-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: fix support for overriding skip_summarization in AgentTool
#324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangfei
requested changes
Apr 22, 2025
Collaborator
hangfei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Please provide a before vs after fix log or screenshot.
Contributor
Author
Collaborator
|
@vgnshiyer Could you share the response you are getting? |
Contributor
Author
test_agent = Agent(
name="test_agent",
description="test_agent",
model="gemini-2.0-flash"
)
root_agent = Agent(
name="RootAgent",
model="gemini-2.0-flash",
description="Root Agent",
tools=[AgentTool(agent=test_agent, skip_summarization=True)],
)
session_service = InMemorySessionService()
session_service.create_session(app_name="test_app", user_id="test_user", session_id="test_session")
runner = Runner(
agent=root_agent,
session_service=session_service,
app_name="test_app",
)
def get_agent_response(query: str):
content = Content(role="user", parts=[Part(text=query)])
events = runner.run(user_id="test_user", session_id="test_session", new_message=content)
for event in events:
if event.is_final_response():
return event.content.parts[0].text
print(get_agent_response("Hello")) |
hangfei
approved these changes
Apr 22, 2025
skip_summarization in AgentToolskip_summarization in AgentTool
skip_summarization in AgentToolskip_summarization in AgentTool
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
-- 94c7f95 by Vignesh Iyer <vgnshiyer@gmail.com>: chore: add support for overriding `skip_summarization` in AgentTool COPYBARA_INTEGRATE_REVIEW=google#324 from vgnshiyer:main 94c7f95 PiperOrigin-RevId: 750060638
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Fixes #173