Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the license header to 2022 #1437

Merged
merged 8 commits into from
Jul 1, 2022
Merged

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Clear and concise code change description.

Alternative(s) considered
NA

Type
Documentation

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94
Copy link
Contributor

Is it better to have a date range: 2021-2022, or just 2022? wdyt?

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #1437 (562c0dd) into master (63fc76f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1437   +/-   ##
=========================================
  Coverage     90.07%   90.07%           
  Complexity      648      648           
=========================================
  Files           129      129           
  Lines          9843     9843           
  Branches        716      716           
=========================================
  Hits           8866     8866           
  Misses          591      591           
  Partials        386      386           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63fc76f...562c0dd. Read the comment docs.

@jingtang10
Copy link
Collaborator Author

Is it better to have a date range: 2021-2022, or just 2022? wdyt?

Actually I think i'll try this: https://github.com/diffplug/spotless/tree/main/plugin-gradle#ratchet

And discussion here: diffplug/spotless#183

@jingtang10
Copy link
Collaborator Author

Is it better to have a date range: 2021-2022, or just 2022? wdyt?

Actually I think i'll try this: https://github.com/diffplug/spotless/tree/main/plugin-gradle#ratchet

And discussion here: diffplug/spotless#183

this is done. @omarismail94 ptal! thanks!

@jingtang10 jingtang10 enabled auto-merge (squash) June 6, 2022 00:31
@jingtang10
Copy link
Collaborator Author

as you can see this change took effect on itself. the header file of the spotlessconfig.kt file has been updated.

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool fix! I like it a lot!! 🎉

@jingtang10
Copy link
Collaborator Author

Unfortunately github actions seem to be failing

FAILURE: Build failed with an exception.
6 actionable tasks: 6 executed
* Where:
Build file '/Users/runner/work/android-fhir/android-fhir/build.gradle.kts' line: 23
* What went wrong:
No such reference 'origin/master'

looking 👀

@jingtang10 jingtang10 merged commit 796a997 into google:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants