Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add immunization measles workflow test #2276

Closed
wants to merge 5 commits into from

Conversation

delcroip
Copy link
Collaborator

@delcroip delcroip commented Oct 21, 2023

Description

add test for measles plandefinition
fix the testing repository implementation by making search nullable (call with null in valueset expand cqframework/clinical-reasoning#365)

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • [x ] I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10
Copy link
Collaborator

can you please give the pr a descriptive name @delcroip? thanks!

@delcroip delcroip changed the title Master google Add immunization measles test Oct 22, 2023
@delcroip delcroip changed the title Add immunization measles test Add immunization measles workflow test Oct 22, 2023
@vorburger vorburger removed their request for review October 27, 2023 13:10
@jingtang10
Copy link
Collaborator

I think this needs gradle spotlessApply to format the code.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @delcroip! so this also download the entire ig to the resource folder? in #2261 the ig is saved in sampledata/smart-imm and here they are saved in resources. do you think it's easy to unify?

@delcroip
Copy link
Collaborator Author

I will have a look into that but I will have to update the content because Jose and Bryn did lot on the measles IG

@delcroip
Copy link
Collaborator Author

Please close this one

@jingtang10
Copy link
Collaborator

thanks @delcroip!

@jingtang10 jingtang10 closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants