Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PatchOrdering.kt #2679

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

GeorgCantor
Copy link

Description

  1. Early Return for DELETE Type
    We immediately return an empty set if the patch type is DELETE, eliminating unnecessary nesting.
  2. Use of flatMap
    Instead of nested loops, we use flatMap to streamline the process of mapping IDs to their corresponding references. This reduces complexity and improves readability.
  3. Avoiding Redundant Calls
    The use of ?: emptyList() ensures that we handle cases where an ID might not be present in the map without additional checks.

Type
Code health

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@GeorgCantor GeorgCantor requested a review from a team as a code owner September 28, 2024 18:53
GeorgCantor and others added 2 commits October 1, 2024 18:28
…/PatchOrdering.kt

Co-authored-by: Jing Tang <jingtang@google.com>
@jingtang10 jingtang10 enabled auto-merge (squash) October 9, 2024 11:01
@jingtang10
Copy link
Collaborator

You need to run spotless before this can be merged. See https://google.github.io/android-fhir/contrib/style/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR under Review
Development

Successfully merging this pull request may close these issues.

2 participants