Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for Activity flow #2735

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aditya-07
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

docs/use/WFL/index.md Outdated Show resolved Hide resolved
docs/use/WFL/Run-an-Activity-Flow.md Show resolved Hide resolved
docs/use/WFL/Run-an-Activity-Flow.md Show resolved Hide resolved
docs/use/WFL/Run-an-Activity-Flow.md Show resolved Hide resolved
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please add a page for the demo app

Copy link
Collaborator

@FikriMilano FikriMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also document the only activities we are currently supporting?

As mentioned, there are:

  1. Send message
  2. Order a medication

docs/use/WFL/Run-an-Activity-Flow.md Show resolved Hide resolved
@aditya-07
Copy link
Collaborator Author

Could you also document the only activities we are currently supporting?

As mentioned, there are:

  1. Send message
  2. Order a medication

Done

@aditya-07
Copy link
Collaborator Author

also please add a page for the demo app

Done

@@ -0,0 +1,20 @@
# Demo App

To demonstrate the capabilities of the Activity Flow api, we have created the *Workflow Demo* app. The app has a Patient card in the top showing the details and a carousel in the bottom with each card representing a particular phase of the activity flow.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To demonstrate the capabilities of the Activity Flow api, we have created the *Workflow Demo* app. The app has a Patient card in the top showing the details and a carousel in the bottom with each card representing a particular phase of the activity flow.
The *Workflow Demo* app demonstrates the capabilities of the Activity Flow API. The app has a Patient card in the top showing the details and a carousel in the bottom with each card representing a particular phase of the activity flow.

optionally: The Workflow Demo app demonstrates the capabilities of CarePlan Generation API and the Activity Flow API.

./gradlew :workflow_demo:installDebug
```

## Steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instructions?

```

## Steps
1. Click on the Initialize button to install the required dependencies for an activity flow. The dependencies are already bundled in the assets folder of the workflow demo app. After the dependencies are successfully installed, Start Button becomes enabled in the Proposal card.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the best formatting is, but feels neater to either have the Intialize and Start text in quotes, or italic, or bold - can you check android dev documentation and try to be consistent (or pick one).


## Steps
1. Click on the Initialize button to install the required dependencies for an activity flow. The dependencies are already bundled in the assets folder of the workflow demo app. After the dependencies are successfully installed, Start Button becomes enabled in the Proposal card.
2. Now, click on the Start to generate a CarePlan which intern has a Proposal Resource. This resource is then used by the app to create a new Activity Flow and the Proposal card now shows the details of the resource with the Start button disabled now. The carousel auto moves to the next Phase Card i.e. Plan.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i woudl put the phase names in italic

## Steps
1. Click on the Initialize button to install the required dependencies for an activity flow. The dependencies are already bundled in the assets folder of the workflow demo app. After the dependencies are successfully installed, Start Button becomes enabled in the Proposal card.
2. Now, click on the Start to generate a CarePlan which intern has a Proposal Resource. This resource is then used by the app to create a new Activity Flow and the Proposal card now shows the details of the resource with the Start button disabled now. The carousel auto moves to the next Phase Card i.e. Plan.
3. Follow the same step as above [2.] to move to the next phases.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeat step 2 to move forward through the phases.

1. Click on the Initialize button to install the required dependencies for an activity flow. The dependencies are already bundled in the assets folder of the workflow demo app. After the dependencies are successfully installed, Start Button becomes enabled in the Proposal card.
2. Now, click on the Start to generate a CarePlan which intern has a Proposal Resource. This resource is then used by the app to create a new Activity Flow and the Proposal card now shows the details of the resource with the Start button disabled now. The carousel auto moves to the next Phase Card i.e. Plan.
3. Follow the same step as above [2.] to move to the next phases.
4. To restart the Activity click Restart Flow that removes all the resources related to the flow and moves the app back to step [2.].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use [] if it doesn't link

4. To restart the Activity click Restart Flow that removes all the resources related to the flow and moves the app back to step [2.].
5. The overflow menu on the action bar may be used to switch between various Activities supported in the demo app.

[!Video](workflow_demo_app.mp4)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a gif might be a lightweight way to do this if video links are problematic

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change code to use a monospace font?

the vertical spacing of the code blocks are not always centre-aligned between two phaces

the update values and states - i wonder if it would look better not in boxes.

also - i always think things look a lot better if you add rounded corner and a very suble drop shadow.

@@ -17,11 +19,14 @@ Future features of the library will provide support for Tasking and other Workfl
## Next Steps

* [Getting Started](Getting-Started.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we normally use sentence case instad of title case? can you double check and make it consistent

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a section for the phase apis.

and then, maybe these different phrase transition apis can be grouped under the same heading in constrast with the phase apis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants