Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking closer at this,
self.__tags
is a dictionary, which is unhashable. Looks like we have two options:__tags
or it's subset, if we can consider Message objects immutable, which we probably cannot.Is there a reason to believe Message objects are immutable? If not, I think making them unhashable makes most sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.__tags
is a dict! I missed that, sorry 🤦♂️I think Message should be mutable. Therefore, it should be unhashable.
This class is hashable in Python 2. Making it unhashable would break compatibility in Python 3. But, that is also an option.
If we make it unhashable, we should add
__hash__ = None
to the class to keep the behaviour consistent in Python 2 as well.OR
If we want to keep behaviour consistent in Python 3, while not breaking compatibility, we should add
__hash__ = object.__hash__
to the class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are good reasons why in Python 3
__hash__
is not implemented by default, in this light, I think the better way to keep compatibility would be to set__hash__ = None
. This may require cascading changes for Py2 users ofapitools
. But same/similar changes would still be needed in downstream codebase to make relevant code Python3-compatible, so that may encourage users of apitools to fix their code sooner than later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! I'll make that change :)