Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clientDataHash to App Attest failure reasons #50

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Mar 28, 2024

  • Replaced the length of the clientDataHash with the actual hash (as base64) in failure reason messages
  • Added the OS version to the message

This provides additional debugging information for firebase/firebase-ios-sdk#12629.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewheard andrewheard merged commit 7a21efd into main Mar 28, 2024
16 checks passed
@andrewheard andrewheard deleted the ah/hash-log branch March 28, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants