Skip to content

Commit

Permalink
[bazel] Use includes instead of strip_include_prefix
Browse files Browse the repository at this point in the history
When using `includes`, consumers will apply the headers
using `-isystem`, instead of `-I`. This will allow diagnostics
of consumers to not apply to `benchmark`.

More info:

https://bazel.build/reference/be/c-cpp#cc_library.includes

https://bazel.build/reference/be/c-cpp#cc_library.strip_include_prefix

gtest uses `includes` as well:
https://github.com/google/googletest/blob/1d17ea141d2c11b8917d2c7d029f1c4e2b9769b2/BUILD.bazel#L120
  • Loading branch information
alexkaratarakis committed Jun 14, 2024
1 parent 8e1823d commit a53f931
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ cc_library(
"_LARGEFILE64_SOURCE",
"_LARGEFILE_SOURCE",
],
strip_include_prefix = "include",
includes = ["include"],
visibility = ["//visibility:public"],
deps = select({
":perfcounters": ["@libpfm"],
Expand All @@ -102,7 +102,7 @@ cc_library(
"include/benchmark/benchmark.h",
"include/benchmark/export.h",
],
strip_include_prefix = "include",
includes = ["include"],
visibility = ["//visibility:public"],
deps = [":benchmark"],
)
Expand Down

0 comments on commit a53f931

Please sign in to comment.