Add a benchmark_deps.bzl function to Google Benchmark
#1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `benchmark_workspace.bzl` function to Google Benchmark. It is intended to be used as a means to pull in Google Benchmark's build dependencies in its own Bazel workspace, as well as in workspaces of downstream projects.
This commit changes Google Benchmark's own WORKSPACE to use the newly created `benchmark_deps.bzl` function.
dmah42
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Bazel setup function, called
benchmark_deps.bzl, to simplify pulling in Google Benchmark's build dependencies into a Bazel workspace for downstream users.Google Benchmark's own WORKSPACE was also migrated to use this new function in a078e7b.
The presented workspace function was modeled off of issue #1510 and references therein, specifically gRPC.
Fixes #1510.