Fix editable install by unsetting build_ext.copy_extensions_to_source
#1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was the culprit for the recent editable install breakage, since it just tries to copy the generated extension file without checking its existence. Since the `BazelExtension` uses a non-standard location to store the build artifacts, calling the copy method fails the build since the extension is not found in the expected location. But, since we already copy the file into the source tree as part of the `BazelExtension.bazel_build` method, it's fine - the extension appears in the right place, and the egg info is generated correctly as well. This method also does not affect the general install, so it solves the editable problem without regressing the fixed install.
|
To check that this works, try to What I would like to test before the merge (because I have run into this before) is whether the |
|
Also, if you prefer moving the extension copy to the |
dmah42
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was the culprit for the recent editable install breakage, since it just tries to copy the generated extension file without checking its existence.
Since the
BazelExtensionuses a non-standard location to store the build artifacts, calling the copy method fails the build since the extension is not found in the expected location.But, since we already copy the file into the source tree as part of the
BazelExtension.bazel_buildmethod, it's fine - the extension appears in the right place, and the egg info is generated correctly as well.This method also does not affect the general install, so it solves the editable problem without regressing the fixed install.