mitigate clang build warnings -Wconversion #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, implicit conversions is perhaps one of the worst C/C++ "features". |
it's in bazel for tests only (!!). i'll see about improving that. |
LebedevRI
reviewed
Mar 6, 2024
include/benchmark/benchmark.h
Outdated
Comment on lines
1306
to
1307
| int ArgsCnt() const; | ||
| const char* GetArgName(int arg) const; | ||
| const char* GetArgName(size_t arg) const; |
There was a problem hiding this comment.
I'm not sure about this one, we return signed and then take unsigned.
I think things should generally be signed, but even then, this seems unconsistent
There was a problem hiding this comment.
yeah i didn't feel great about that either. i'll tweak it.
LebedevRI
reviewed
Mar 6, 2024
| @@ -24,7 +24,7 @@ typename std::vector<T>::iterator AddPowers(std::vector<T>* dst, T lo, T hi, | |||
| static const T kmax = std::numeric_limits<T>::max(); | |||
|
|
|||
| // Space out the values in multiples of "mult" | |||
There was a problem hiding this comment.
I'm somewhat surprized that this is needed, but okay, i guess?
LebedevRI
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.