Only enable "-pedantic-errors" when BENCHMARK_ENABLE_WERROR is ON #1775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of clang (on Windows at least) fail to compile benchmark with
-Werror
and-pedantic-errors
.Unfortunately, the
BENCHMARK_ENABLE_WERROR
option toggles only-Werror
, and not-pedantic-errors
.This PR changes the CMakeLists.txt file to only append
-pedantic-errors
whenBENCHMARK_ENABLE_WERROR
is ON