Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nanobind_bazel to v2.2.0 #1866

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

nicholasjng
Copy link
Contributor

Adds support for free-threaded nanobind extension builds, though we don't currently build a free-threaded wheel.

Adds support for free-threaded nanobind extension builds, though we
don't currently build a free-threaded wheel.
@nicholasjng
Copy link
Contributor Author

Since Python 3.13 has been released, I'll also add it to cibuildwheel and the Python bindings test matrix shortly if that's ok with you.

@dmah42
Copy link
Member

dmah42 commented Oct 23, 2024

looks like googletest got accidentally upgraded (WARNING: For repository 'com_google_googletest', the root module requires module version googletest@1.12.1, but got googletest@1.14.0 in the resolved dependency graph.)

amongst others:

WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.5.0, but got bazel_skylib@1.7.1 in the resolved dependency graph.
WARNING: For repository 'platforms', the root module requires module version platforms@0.0.8, but got platforms@0.0.10 in the resolved dependency graph.
WARNING: For repository 'rules_python', the root module requires module version rules_python@0.31.0, but got rules_python@0.37.0 in the resolved dependency graph.
WARNING: For repository 'com_google_googletest', the root module requires module version googletest@1.12.1, but got googletest@1.14.0 in the resolved dependency graph.

we might want to do an explicit upgrade before this can land.

@dmah42
Copy link
Member

dmah42 commented Oct 23, 2024

#1867 should do it

@nicholasjng
Copy link
Contributor Author

Sure. Is there another version before their latest C++17 upgrade? Otherwise this might have to wait for the upgrade to C++17.

@dmah42 dmah42 merged commit be21345 into google:main Oct 23, 2024
80 checks passed
@dmah42
Copy link
Member

dmah42 commented Oct 23, 2024

thank you for your continued maintenance of this dark corner of the project!

@nicholasjng
Copy link
Contributor Author

My pleasure, I'll be here for a while :^)

@nicholasjng nicholasjng deleted the bump-nanobind-bazel branch October 23, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants